Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API: Provided Samplers in the SDK #87

Closed
bogdandrutu opened this issue Jun 6, 2019 · 3 comments · Fixed by #296
Closed

API: Provided Samplers in the SDK #87

bogdandrutu opened this issue Jun 6, 2019 · 3 comments · Fixed by #296
Assignees
@bogdandrutu
Labels
area:sampling Related to trace sampling
Milestone
Alpha v0.2

Comments

@bogdandrutu
Copy link
Member

Currently we in the API we provide implementation of the Samplers with alwaysOn and alwaysOff (neverSample).

Proposing:

  1. Change the name to more clear names as defined in https:/open-telemetry/opentelemetry-proto/blob/master/src/opentelemetry/proto/trace/v1/trace_config.proto#L53
  2. Add the AlwaysParent sampler which probably should be the default Sampler when no implementation linked.
@SergeyKanzhelev

This comment has been minimized.

Sign in to view
@bogdandrutu

This comment has been minimized.

Sign in to view
@SergeyKanzhelev SergeyKanzhelev transferred this issue from open-telemetry/opentelemetry-java Jun 8, 2019
@SergeyKanzhelev SergeyKanzhelev added this to the API revision: 07-2019 milestone Jun 8, 2019
@iredelmeier iredelmeier added the area:sampling Related to trace sampling label Jul 30, 2019
@SergeyKanzhelev SergeyKanzhelev modified the milestones: API revision: 07-2019, Alpha v0.2 Sep 27, 2019
@SergeyKanzhelev SergeyKanzhelev changed the title API: Provided Samplers in the API API: Provided Samplers in the SDK Oct 2, 2019
@SergeyKanzhelev
Copy link
Member

@bogdandrutu assigned to you as you are working on sampling PRs.

@bogdandrutu bogdandrutu mentioned this issue Oct 10, 2019
Merged
TuckTuckFloof pushed a commit to TuckTuckFloof/opentelemetry-specification that referenced this issue Oct 15, 2020
Add function to fill a buffer with random bytes (open-telemetry#87)
273a0ae
rockb1017 pushed a commit to rockb1017/opentelemetry-specification that referenced this issue Nov 18, 2021
@flands @MrAlias
Approvers now get Write permission (open-telemetry#88)
de2476d 
* Approvers now get Write permission

In order to support CODEOWNERS for approvers (no GH action), grant
approvers Write access. This follows the OTel model. Addresses open-telemetry#87

* Remove action

* Re-add CODEOWNERS template

* Fix files

* Update specification/templates/.github/CODEOWNERS

Co-authored-by: Tyler Yahn <[email protected]>

* Update specification/templates/.github/CODEOWNERS

Co-authored-by: Mateusz Rzeszutek <[email protected]>

Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Mateusz Rzeszutek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bogdandrutu bogdandrutu

Labels
area:sampling Related to trace sampling
Projects
None yet
Milestone
Alpha v0.2
Development

Successfully merging a pull request may close this issue.

Update Sampler interface base on OTEP 0006-sampling bogdandrutu/opentelemetry-specification
4 participants
@bogdandrutu @iredelmeier @pavolloffay @SergeyKanzhelev