Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent Sampling Result Names #940

Closed
ejsmith opened this issue Sep 11, 2020 · 1 comment · Fixed by #938 or #956
Closed

Inconsistent Sampling Result Names #940

ejsmith opened this issue Sep 11, 2020 · 1 comment · Fixed by #938 or #956
Labels
area:api Cross language API specification issue area:sampling Related to trace sampling priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory

Comments

@ejsmith
Copy link
Contributor

ejsmith commented Sep 11, 2020

Current Names

  • NOT_RECORD
  • RECORD
  • RECORD_AND_SAMPLED

Seems like we should pick between present tense or past tense and make it consistent. I am proposing that we use past tense as in it's a decision that has already been made.

NOT_RECORD doesn't make sense. It is not correct English.

Related: #938
@ejsmith ejsmith added the spec:trace Related to the specification/trace directory label Sep 11, 2020
@ejsmith ejsmith mentioned this issue Sep 11, 2020
Merged
@andrewhsu andrewhsu added area:api Cross language API specification issue area:sampling Related to trace sampling labels Sep 11, 2020
@Oberon00 Oberon00 linked a pull request Sep 11, 2020 that will close this issue
Inconsistent Sampling Result Names #938
Merged
@Oberon00 Oberon00 added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Sep 14, 2020
@andrewhsu andrewhsu added the priority:p3 Lowest priority level label Sep 15, 2020
@andrewhsu
Copy link
Member

from the spec sig mtg today, set priority to p3

@arminru arminru linked a pull request Sep 17, 2020 that will close this issue
Rename Ignore to Drop for SamplingResult #956
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area:api Cross language API specification issue area:sampling Related to trace sampling priority:p3 Lowest priority level release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
3 participants
@andrewhsu @ejsmith @Oberon00