-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default aggregation for SumObserver and UpDownSumObserver #944
Comments
It seems the issue in question is already solved in the Spec. However, it may still be sensible to have this issue to make @open-telemetry/java-approvers and @open-telemetry/python-approvers and potentially other SIGs aware their implementation is not compliant. The metric compliance matrix is still TBD currently I think. |
@nilebox in this case it really does not matter, because we specifically say that observers are called once per collection interval, but it may be that the observer returns multiple values for the same combination of labels (which I think is forbidden by the specs). That being said consistency should be there, and we should change all the SDKs to use the same aggregation. |
Update on Java.
|
I think this is addressed by #1842. Please reopen if anything not covered by the SDK spec. |
What are you trying to achieve?
Review requirements for default aggregation for
SumObserver
andUpDownSumObserver
, and confirm what should be the behavior in all SDKs for consistency.First of all, SDKs currently implement aggregation for
SumObserver
andUpDownSumObserver
differently:According to spec, they should be using the
Sum
aggregation: https:/open-telemetry/opentelemetry-specification/blob/master/specification/metrics/api.md#aggregationsIf there is exactly one data point per measurement interval, there is no difference between using
LastValue
vsSum
as far as I understand. It may be important for consistency and correct handling of cases where there happens to be more than one data point per interval though.Additional context.
There are other cases of inconsistency in aggregation, e.g.
ValueObserver
which has reached consensus to useLastValue
in all SDKs, but the spec still states that it should be using MinMaxSumCount. UPDATE: created #945 to track separately./cc @jmacd @james-bebbington @bogdandrutu
The text was updated successfully, but these errors were encountered: