Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CHANGELOG and OTLP env vars with the latest names. #1398

Merged

Conversation

carlosalberto
Copy link
Contributor

Follow up to #1358

  • Adds a CHANGELOG entry
  • Updates the OTLP environment variables with the actual latest names.

Removed an example that is not valid anymore as well.

Comment on lines +60 to +61
- Modify OTLP/Zipkin Exporter format variables for 1.0 (allowing further specification post 1.0)
([#1358](https:/open-telemetry/opentelemetry-specification/pull/1358))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any Zipkin-related changes in this PR. Did you intend to mention Zipkin here or only OTLP?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlosalberto
Copy link
Contributor Author

Merging as this was simply a simple follow up of an already approved PR.

@carlosalberto carlosalberto merged commit c538693 into open-telemetry:main Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants