Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify aggregation temporality selection #2132

Conversation

reyang
Copy link
Member

@reyang reyang commented Nov 16, 2021

Fixes #2129

Changes

Clarified that the SDK has access to the MetricReader temporality, and the MetricReader could/should proxy the temporality of its underlying MetricExporter (if there is one).

@reyang reyang requested review from a team November 16, 2021 21:04
@reyang reyang added area:sdk Related to the SDK spec:metrics Related to the specification/metrics directory labels Nov 16, 2021
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
specification/metrics/sdk.md Show resolved Hide resolved
specification/metrics/sdk.md Outdated Show resolved Hide resolved
Copy link
Member

@cijothomas cijothomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good clarifications!

@jsuereth jsuereth enabled auto-merge (squash) November 23, 2021 17:18
@jsuereth jsuereth merged commit 29e776a into open-telemetry:main Nov 23, 2021
@reyang reyang deleted the reyang/metrics-aggregation-temporality-selection branch November 23, 2021 17:21
@reyang reyang added the release:required-for-ga Must be resolved before GA release, or nice to have before GA label Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:sdk Related to the SDK release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:metrics Related to the specification/metrics directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clarify SDK/MetricReader/MetricExporter boundaries
6 participants