Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct description of OTEL_EXPORTER_JAEGER_ENDPOINT and OTEL_TRACES_EXPORTER #2333

Merged
merged 11 commits into from
Feb 13, 2022
Merged

Correct description of OTEL_EXPORTER_JAEGER_ENDPOINT and OTEL_TRACES_EXPORTER #2333

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
4241608
Change description/default of OTEL_EXPORTER_JAEGER_ENDPOINT to point …
yurishkuro Feb 10, 2022
e90c7eb
url
yurishkuro Feb 10, 2022
fe78411
fix
yurishkuro Feb 10, 2022
1b569c4
footnotes
yurishkuro Feb 10, 2022
43c719f
cr
yurishkuro Feb 10, 2022
18d6cfe
fix
yurishkuro Feb 10, 2022
ee98cd1
fix
yurishkuro Feb 10, 2022
c0f24ad
fix
yurishkuro Feb 11, 2022
201906f
Merge branch 'main' into fix-jaeger-port
yurishkuro Feb 11, 2022
e52c1fd
Merge branch 'main' into fix-jaeger-port
carlosalberto Feb 11, 2022
5841113
Merge branch 'main' into fix-jaeger-port
yurishkuro Feb 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ release.
- Add support for probability sampling in the OpenTelemetry `tracestate` entry and
add optional specification for consistent probability sampling.
([#2047](https:/open-telemetry/opentelemetry-specification/pull/2047))
- Change description and default value of OTEL_EXPORTER_JAEGER_ENDPOINT env var
to point to the correct HTTP port
([#2333](https:/open-telemetry/opentelemetry-specification/pull/2333)).

### Metrics

Expand Down
4 changes: 3 additions & 1 deletion specification/sdk-environment-variables.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ See [OpenTelemetry Protocol Exporter Configuration Options](./protocol/exporter.
|---------------------------------|------------------------------------------------------------------|--------------------------------------------------------------------------------------------------|
| OTEL_EXPORTER_JAEGER_AGENT_HOST | Hostname for the Jaeger agent | "localhost" |
| OTEL_EXPORTER_JAEGER_AGENT_PORT | Port for the Jaeger agent `compact` Thrift protocol | 6831 |
| OTEL_EXPORTER_JAEGER_ENDPOINT | HTTP endpoint for Jaeger traces | <!-- markdown-link-check-disable --> "http://localhost:14250"<!-- markdown-link-check-enable --> |
| OTEL_EXPORTER_JAEGER_ENDPOINT | Full URL of [Thrift over HTTP][[jaeger_http]] endpoint for Jaeger traces | <!-- markdown-link-check-disable --> "http://localhost:14268/api/traces"<!-- markdown-link-check-enable --> |
yurishkuro marked this conversation as resolved.
Show resolved Hide resolved
| OTEL_EXPORTER_JAEGER_TIMEOUT | Maximum time the Jaeger exporter will wait for each batch export | 10s |
| OTEL_EXPORTER_JAEGER_USER | Username to be used for HTTP basic authentication | |
| OTEL_EXPORTER_JAEGER_PASSWORD | Password to be used for HTTP basic authentication | |
Expand Down Expand Up @@ -222,3 +222,5 @@ To ensure consistent naming across projects, this specification recommends that
```
OTEL_{LANGUAGE}_{FEATURE}
```

[jaeger_http]: https://www.jaegertracing.io/docs/latest/apis/#thrift-over-http-stable