Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat env vars table for OTLP exporter. #2345

Merged
merged 5 commits into from
Feb 16, 2022
Merged

Reformat env vars table for OTLP exporter. #2345

merged 5 commits into from
Feb 16, 2022

Conversation

anuraaga
Copy link
Contributor

Changes

No change in content just moves the items into a list form to make it easier to add new entries as found in #2330

@anuraaga anuraaga requested review from a team February 15, 2022 06:21
@anuraaga anuraaga changed the title Remformat env vars table for OTLP exporter. Reformat env vars table for OTLP exporter. Feb 15, 2022
@anuraaga anuraaga mentioned this pull request Feb 15, 2022
Closed
pirgeo
pirgeo approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@pirgeo pirgeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think putting the bullet point headings (Endpoint (OTLP/HTTP, Insecure, etc.) in bold might be a good idea, just to have some visual cue when looking for something on this page. This is what I would expect people to use this page for.

specification/protocol/exporter.md Show resolved Hide resolved
yurishkuro
yurishkuro approved these changes Feb 15, 2022
View reviewed changes
Copy link
Member

@yurishkuro yurishkuro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 to bold the entry titles (as was suggested in my original comment)

@pellared pellared mentioned this pull request Feb 15, 2022
Merged
@tigrannajaryan
Copy link
Member

@anuraaga this should be good to merge once rebased and all comments resolved.

@yurishkuro yurishkuro merged commit 2560752 into open-telemetry:main Feb 16, 2022
@pellared pellared mentioned this pull request Feb 18, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yurishkuro yurishkuro yurishkuro approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

@pirgeo pirgeo pirgeo approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@anuraaga @tigrannajaryan @yurishkuro @pirgeo @arminru