[editorial] Add space in schemas/overview #2351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For context, see https:/open-telemetry/opentelemetry-specification/pull/2320/files#r807334158. /cc @arminru Btw, would it not be better to use code markdown (like `Resource*`) rather than having to escape `*` when used as plain text?
tigrannajaryan
approved these changes
Feb 15, 2022
arminru
approved these changes
Feb 16, 2022
There was a problem hiding this comment.
Thanks, @chalin! And yes, when referring to the name of the message as it's defined in https:/open-telemetry/opentelemetry-proto, using code formatting would make sense. It would be nice if you could change it accordingly or otherwise I can take it as well.
arminru
added
the
editorial
carlosalberto
approved these changes
Feb 16, 2022
Ok, how about we leave this PR as is. I have other higher priority issues to tackle at the moment, but I'll make the changes you suggest if/when I touch this file again. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For context, see #2320 at https:/open-telemetry/opentelemetry-specification/pull/2320/files#r807334158.
/cc @arminru
Btw, wouldn't be better to use code markdown (like
Resource*) rather than having to escape*when used as plain text?