Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add postgresql metrics semantic conventions #2544

Closed
wants to merge 9 commits into from
Closed

Add postgresql metrics semantic conventions #2544

wants to merge 9 commits into from

Conversation

hecomp
Copy link

@hecomp hecomp commented May 17, 2022 •
edited
Loading

Added Postgres metrics from Postgres Metrics Receiver

All these are the original metrics/values, with the only change of including db as a prefix.

Added

  • blocks_read
  • commits
  • db_size
  • backends
  • row.count
  • operation.count
  • rollbacks

@hecomp hecomp requested review from a team May 17, 2022 20:39
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented May 17, 2022 •
edited
Loading

CLA Signed

The committers listed above are authorized under a signed CLA.

@carlosalberto carlosalberto changed the title Postgres metrics addition Add postgresql metrics semantic conventions May 17, 2022
@carlosalberto
Copy link
Contributor

Ping @djaglowski as the author/maintainer of the Postgresql receiver in Collector contrib.

reyang
reyang reviewed May 18, 2022
View reviewed changes
specification/metrics/semantic_conventions/instrumentation/postgres.md Outdated
| | | | | | | `table` | The schema name followed by the table name. |
| | | | | | | `source` | The block read source type. |
| | | | | | | | `heap_read`, `heap_hit`, `idx_read`, `idx_hit`, `toast_read`, `toast_hit`, `tidx_read`, `tidx_hit` |
| db.postgresql.commits | Counter | Int64 | commits | `{commits}` | The number of commits. | `database` | The number of active connections. |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about distributed transactions? Does Postgres SQL offer 2PC (two-phase commit)?

@reyang reyang added the area:semantic-conventions Related to semantic conventions label May 18, 2022
@arminru arminru added spec:metrics Related to the specification/metrics directory semconv:database labels May 18, 2022
@tigrannajaryan
Copy link
Member

@djaglowski you are the codeowner of this component in Collector, it would be great if you can review this PR.

@tigrannajaryan
Copy link
Member

@dehaansa you are the author of this component in Collector, it would be great if you can review this PR.

@hecomp hecomp requested review from reyang May 18, 2022 22:36
@hecomp hecomp requested a review from lalitb May 18, 2022 22:36
@hecomp hecomp force-pushed the postgres-metrics-addition branch from d0edc56 to 259b57f Compare May 23, 2022 14:38
@hecomp hecomp requested a review from djaglowski May 23, 2022 14:46
@hecomp hecomp requested review from arminru and djaglowski May 23, 2022 18:30
@hecomp hecomp mentioned this pull request May 24, 2022
Closed
@github-actions
Copy link

github-actions bot commented Jun 1, 2022

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 1, 2022
@tigrannajaryan
Copy link
Member

If I remember correctly in the Spec SIG meeting last week we discussed the topic of having semantic conventions for specific technologies in Otel spec and the conclusion was that we need some guidance around how widely applicable the conventions should be to have a place in Otel spec and whether we want specific technologies like Postgres or Mysql to have their conventions defined here.

@carlosalberto I think you mentioned that you were going to file an issue for this (if I remember correctly, I may be wrong, maybe it wasn't you, it was someone else). Do we have the issue to track this?

@github-actions github-actions bot removed the Stale label Jun 2, 2022
@tigrannajaryan
Copy link
Member

@carlosalberto I think you mentioned that you were going to file an issue for this (if I remember correctly, I may be wrong, maybe it wasn't you, it was someone else). Do we have the issue to track this?

@carlosalberto can you please tell if this happened?

@jack-berg
Copy link
Member

@tigrannajaryan Issue #2610 was created to track / discuss this.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Jun 17, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@github-actions github-actions bot closed this Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djaglowski djaglowski djaglowski approved these changes

@carlosalberto carlosalberto Awaiting requested review from carlosalberto

@reyang reyang Awaiting requested review from reyang

@lalitb lalitb Awaiting requested review from lalitb

@arminru arminru Awaiting requested review from arminru

Assignees

@jmacd jmacd

Labels
area:semantic-conventions Related to semantic conventions semconv:database spec:metrics Related to the specification/metrics directory Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@hecomp @carlosalberto @tigrannajaryan @jack-berg @lalitb @djaglowski @arminru @reyang @jmacd