Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSearch in the database group #2718

Merged
merged 5 commits into from
Aug 11, 2022

Conversation

sharp-pixel
Copy link
Contributor

@sharp-pixel sharp-pixel commented Aug 8, 2022

This PR adds OpenSearch in the database section of semantic conventions.
This is necessary for example to provide support for java instrumentation of OpenSearch clients.

Signed-off-by: Cédric Pelvet [email protected]

@sharp-pixel sharp-pixel requested review from a team August 8, 2022 15:48
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 8, 2022

CLA Signed

The committers listed above are authorized under a signed CLA.

reyang
reyang previously approved these changes Aug 8, 2022
@reyang
Copy link
Member

reyang commented Aug 8, 2022

@sharp-pixel would you clear the CLA?

@sharp-pixel
Copy link
Contributor Author

CLA is now clear

@sharp-pixel
Copy link
Contributor Author

Fixed spelling of OpenSearch

@sharp-pixel
Copy link
Contributor Author

I tried to run the docker run --rm -v $PWD/semantic_conventions:/source -v $PWD/specification:/spec otel/semconvgen:0.12.1 -f /source markdown -md /spec --md-check command on the database.md file manually and it seems that even the previous version (before my changes) returns the error.

Something must have changed in the semconvgen check. I also tried the newer 0.13.0 image without success.

The problem is that it is difficult to guess what I need to do to fix it as the error message is pretty useless:

File /spec/trace/semantic_conventions/database.md contains a table that would be reformatted.

Can someone point me to the semconvgen source code?

@joaopgrassi
Copy link
Member

Please, make sure to add an entry to the changelog under ## Unreleased > ### Semantic Conventions

@sharp-pixel
Copy link
Contributor Author

sharp-pixel commented Aug 9, 2022

Added to changelog

Signed-off-by: Cédric Pelvet <[email protected]>
Signed-off-by: Cédric Pelvet <[email protected]>
Signed-off-by: Cédric Pelvet <[email protected]>
@sharp-pixel
Copy link
Contributor Author

The markdown-link-check errors seem to be transient as the link(s) in error seems to be working fine.

CHANGELOG.md Outdated Show resolved Hide resolved
CHANGELOG.md Outdated Show resolved Hide resolved
@joaopgrassi joaopgrassi added the area:semantic-conventions Related to semantic conventions label Aug 10, 2022
Signed-off-by: Cédric Pelvet <[email protected]>
@joaopgrassi
Copy link
Member

@open-telemetry/specs-trace-approvers I think this is good to go :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:semantic-conventions Related to semantic conventions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants