[resource] add openshift platform to all supported cloud providers

[frzifus]

Signed-off-by: Benedikt Bongartz [email protected]

Fixes #2970

Additional information

https://aws.amazon.com/de/rosa/
https://www.alibabacloud.com/solutions/redhat-openshift
https://azure.microsoft.com/de-de/products/openshift/
https://console.cloud.google.com/marketplace/browse?q=red%20hat%20openshift&pli=1

[joaopgrassi]

Looks good to the me!

[Oberon00]

This seems to be a non-native "Marketplace" feature. I don't really know how these work, is it built on top of other public-facing products of the platform? Do we actually need entries in the enum for that? If we include marketplace offerings, it might make the size of this enumeration potentially endless.

[frzifus]

I don't really know how these work, is it built on top of other public-facing products of the platform?

Exactly, for example in aws openshift uses ec2 instances as nodes.

Do we actually need entries in the enum for that?

I would argue - yes. Although openshift uses ec2 instances, they are abstracted away. Which in my view makes openshift the platform. Nothing else happens with eks, which uses ec2 instances and its is also listed as a platform on aws. In both cases its more beneficial to know the underlying platform that potentially caused issues is eks or openshift then ec2.

If we include marketplace offerings, it might make the size of this enumeration potentially endless.

This depends very much on the definition of a platform. My feeling is that there are not many different platform solutions in the marketplaces.

[carlosalberto]

Overall LGTM although @Oberon00 raised a good point regarding the potential explosion of values here. Let's try to get more eyes on this, just to stay on the safe side.

[joaopgrassi]

One could argue that we already have such things. We have in the enum several cloud k8s managed services (e.g., Azure AKS). I think adding OpenShift is pretty much following the same logic. If we don't want this then maybe we should rethink the existing entries. For ex, instead of listing the cloud products, just list "k8s". But I think that's not great, so I'm in favor of keeping the actual cloud "platforms" they offer.

[frzifus]

Whats needed to move on?

[carlosalberto]

Merging for completeness purposes (we have similar sections for other cloud providers/services). Let's consider discussing either limiting or redefining them if/when needed (hopefully not, etc).