Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenCensus propagators as allowed in OTel repositories #3035

Merged
merged 1 commit into from
Jan 12, 2023

Conversation

dashpole
Copy link
Contributor

Part of #1175

Addresses #3015 (comment). We don't currently list OpenCensus propagators anywhere in our specification, even though they have been implemented (e.g. go's BinaryFormat propagator).

This does not require implementing these propagators, but adds them to the list of propagators allowed in core repositories. My primary motivation is to document them somewhere in the specification for reference.

cc @jsuereth @bogdandrutu @jack-berg @reyang

@dashpole
Copy link
Contributor Author

cc @carlosalberto as well

I stumbled on #437. It looks like the w3c spec is still a draft. I would like to propose that we allow re-adding the binary propagator purely as a tool to facilitate migrations from OpenCensus, without tackling the introduction of a standardized w3c binary propagator.

@carlosalberto
Copy link
Contributor

Correct, we will need to allow binary propagation. I think it's totally fine to mention we only support binary for OC for now.

@github-actions
Copy link

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Dec 22, 2022
@github-actions
Copy link

Closed as inactive. Feel free to reopen if this PR is still being worked on.

@carlosalberto
Copy link
Contributor

Approving but we should do a follow up (requirement?) issue to clarify the binary propagation in the related section (for which an OC binary propagator in an additional language should be implemented, as a way to exercise it, etc)

@carlosalberto
Copy link
Contributor

cc @bogdandrutu

@reyang reyang merged commit 9b022c9 into open-telemetry:main Jan 12, 2023
@dashpole dashpole deleted the add_oc_propagators branch January 12, 2023 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants