Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add condition with sum and count for Prometheus summaries #3059

Merged
merged 8 commits into from
Jan 23, 2023
+4 −0
Merged

Add condition with sum and count for Prometheus summaries #3059

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6b05705
Add condition with sum and count for prometheus summaries
khanhntd Dec 21, 2022
5debba7
Add condition with sum and count for prometheus summaries
khanhntd Dec 21, 2022
3cd0591
Add condition with sum and count for prometheus summaries
khanhntd Jan 5, 2023
9ceb21a
Add condition with sum and count for prometheus summaries
khanhntd Jan 10, 2023
fa143a2
Merge branch 'main' of https:/open-telemetry/opentelemetr…
khanhntd Jan 19, 2023
c11316c
Merge branch 'main' into update_summaries
khanhntd Jan 19, 2023
7c2e604
Merge from main
khanhntd Jan 19, 2023
d263452
Merge branch 'main' into update_summaries
reyang Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ release.

### Compatibility

- Add condition with sum and count for prometheus summaries
khanhntd marked this conversation as resolved.
Show resolved Hide resolved
([3059]https:/open-telemetry/opentelemetry-specification/pull/3059)

### OpenTelemetry Protocol

- Add table for OTLP/HTTP response code and client retry recommendation
Expand Down
2 changes: 2 additions & 0 deletions specification/compatibility/prometheus_and_openmetrics.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,6 +103,8 @@ Multiple Prometheus metrics are merged together into a single OTLP Summary:

* The `quantile` label on non-suffixed metrics is used to identify quantile points in summary metrics. Each Prometheus line produces one quantile on the resulting summary.
* Lines with `_count` and `_sum` suffixes are used to determine the summary's count and sum.
* If `_count` is not present, the metric MUST be dropped.
* If `_sum` is not present, the summaries's sum MUST be [set to zero.](https:/open-telemetry/opentelemetry-proto/blob/d8729d40f629dba12694b44c4c32c1eab109b00a/opentelemetry/proto/metrics/v1/metrics.proto#L601)
khanhntd marked this conversation as resolved.
Show resolved Hide resolved

### Dropped Types

Expand Down