Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Apache HTTP Server access log example mapping #3114

Merged
merged 7 commits into from
Feb 7, 2023

Conversation

pellared
Copy link
Member

@pellared pellared commented Jan 19, 2023

Why

Cleanup after: #2614, #2469

Discovered when reviewing: #3087

What

Update Apache HTTP Server access log example mapping to match current semantic conventions.

@pellared pellared requested review from a team January 19, 2023 11:13
@pellared
Copy link
Member Author

@lmolkova PTAL

Copy link
Contributor

@lmolkova lmolkova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@arminru arminru added spec:logs Related to the specification/logs directory area:data-model For issues related to data model labels Jan 31, 2023
specification/logs/data-model.md Outdated Show resolved Hide resolved
specification/logs/data-model.md Outdated Show resolved Hide resolved
Copy link
Member Author

@pellared pellared left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@arminru Thanks for your review. Can you take a quick look at my suggestions?

specification/logs/data-model.md Outdated Show resolved Hide resolved
specification/logs/data-model.md Outdated Show resolved Hide resolved
@pellared
Copy link
Member Author

pellared commented Feb 7, 2023

@open-telemetry/specs-approvers Is it good to merge? 😉

@reyang reyang merged commit 26e98fc into open-telemetry:main Feb 7, 2023
@pellared pellared deleted the cleanup branch February 8, 2023 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:data-model For issues related to data model spec:logs Related to the specification/logs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants