Remove restriction that sampler description is immutable #4137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yuri Shkuro <[email protected]>
pellared
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
While this can be seen as a breaking change for the callers (previously it was allowing caching - now it is not) I personally see it more like a bugfix.
In Go SDK we never had indicated that callers may cache the results and I do not found any code that would rely on that. Go docs for Sampler: https://pkg.go.dev/go.opentelemetry.io/otel/sdk/trace#Sampler
Can you add a changelog entry? 😉
Signed-off-by: Yuri Shkuro <[email protected]>
lmolkova
approved these changes
Jul 10, 2024
reyang
approved these changes
Jul 10, 2024
reyang
reviewed
Jul 10, 2024
reyang
approved these changes
Jul 10, 2024
pellared
reviewed
Jul 10, 2024
jack-berg
approved these changes
Jul 10, 2024
There was a problem hiding this comment.
I see this as a bugfix. The arguments here are convincing.
I think we should assume that there are no implementations caching this since this seems reasonable, but leave this open for a period of time which allows people to come forward and claim otherwise. Say 2-3 weeks.
cijothomas
approved these changes
Jul 11, 2024
jmacd
approved these changes
Jul 15, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2095
Changes
State that sampler description can change over time. Provide examples.