Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for filtering attribute keys for streams via an exclude list #4188

Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,9 @@ release.

### Metrics

- Add support for filtering attribute keys for streams via an exclude list.
([#4188](https:/open-telemetry/opentelemetry-specification/pull/4188))

### Logs

- Clarify that log record mutations are visible in next registered processors.
Expand Down
1 change: 1 addition & 0 deletions spec-compliance-matrix.md
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ formats is required. Implementing more than one format is optional.
| The `View` instrument selection criteria supports the match-all wildcard. | | | + | + | + | | + | | + | + | + | |
| The name of the `View` can be specified. | | | + | + | + | | + | + | | + | + | |
| The `View` allows configuring the name, description, attributes keys and aggregation of the resulting metric stream. | | | + | + | + | | + | + | + | + | - | |
| The `View` allows configuring excluded attribute keys of resulting metric stream. | | + | | | | | | | | | | |
| The `View` allows configuring the exemplar reservoir of resulting metric stream. | X | | - | | - | | - | | | | - | |
| The SDK allows more than one `View` to be specified per instrument. | X | | + | + | + | | + | | + | + | + | |
| The `Drop` aggregation is available. | | + | + | + | + | | + | | + | + | + | |
Expand Down
6 changes: 6 additions & 0 deletions specification/metrics/sdk.md
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,12 @@ The SDK MUST accept the following stream configuration parameters:
parameter configured on the instrument instead. If the `Attributes`
advisory parameter is absent, all attributes MUST be kept.

Additionally, implementations SHOULD support configuring an exclude-list of
attribute keys. The exclude-list contains attribute keys that identify the
attributes that MUST be excluded, all other attributes MUST be kept. If an
attribute key is both included and excluded, implementations MAY cause the
cijothomas marked this conversation as resolved.
Show resolved Hide resolved
application to fail on initialization.

* `aggregation`: The name of an [aggregation](#aggregation) function to use in
aggregating the metric stream data.

Expand Down
Loading