Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Resource spec based on the move to the SDK and named tracers #421

Merged
merged 8 commits into from
Jan 30, 2020

Conversation

tsloughter
Copy link
Member

The Resource spec was moved from the API to the SDK but it still referred to the API in the text. This also updates to reference the Providers and all the tracers that may be retrieved from the provider (named tracers and meters).

Copy link
Contributor

@MrAlias MrAlias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Made some minor grammatical suggestions.

Copy link
Contributor

@jkwatson jkwatson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the addition of one 'The'

@bogdandrutu bogdandrutu reopened this Jan 30, 2020
@bogdandrutu bogdandrutu merged commit 3bbed37 into open-telemetry:master Jan 30, 2020
MikeGoldsmith added a commit to MikeGoldsmith/opentelemetry-specification that referenced this pull request Feb 6, 2020
…elemetry-specification into remove-binary-format

* 'remove-binary-format' of github.com:MikeGoldsmith/opentelemetry-specification:
  update Resource spec based on the move to the SDK and named tracers (open-telemetry#421)
  sdk-tracer: replace Factory with Provider (open-telemetry#422)
  Add details for determining the parent Span from a Context (open-telemetry#423)
SergeyKanzhelev pushed a commit to SergeyKanzhelev/opentelemetry-specification that referenced this pull request Feb 18, 2020
…pen-telemetry#421)

* update Resource spec based on the move to the SDK and named tracers

* Update specification/sdk-resource.md

Co-Authored-By: Tyler Yahn <[email protected]>

* Update specification/sdk-resource.md

Co-Authored-By: Tyler Yahn <[email protected]>

* Update specification/sdk-resource.md

Co-Authored-By: Tyler Yahn <[email protected]>

* provide example of what the entity producing telemetry means

* Update specification/sdk-resource.md

Co-Authored-By: John Watson <[email protected]>

Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: John Watson <[email protected]>
Co-authored-by: Bogdan Drutu <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants