Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CHANGELOG entry for exceptions. #778

Merged
merged 1 commit into from
Aug 11, 2020
Merged

Add CHANGELOG entry for exceptions. #778

merged 1 commit into from
Aug 11, 2020

Conversation

Oberon00
Copy link
Member

This is a follow-up to #697 which was missing a CHANGELOG entry.

CC @mwear, @iNikem

@Oberon00 Oberon00 added area:api Cross language API specification issue area:semantic-conventions Related to semantic conventions area:error-reporting Related to error reporting spec:trace Related to the specification/trace directory release:required-for-ga Must be resolved before GA release, or nice to have before GA labels Aug 11, 2020
@Oberon00 Oberon00 requested review from a team and yurishkuro August 11, 2020 09:06
@Oberon00 Oberon00 mentioned this pull request Aug 11, 2020
Closed
@carlosalberto carlosalberto self-requested a review August 11, 2020 15:20
mwear
mwear approved these changes Aug 11, 2020
View reviewed changes
Copy link
Member

@mwear mwear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bogdandrutu
Copy link
Member

Trivial change, don't have to wait 48h :)

@bogdandrutu bogdandrutu merged commit 9064c67 into open-telemetry:master Aug 11, 2020
@Oberon00 Oberon00 deleted the add-changelog-entry-for-exceptions branch December 18, 2020 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlosalberto carlosalberto carlosalberto approved these changes

@bogdandrutu bogdandrutu bogdandrutu approved these changes

@mwear mwear mwear approved these changes

@iNikem iNikem iNikem approved these changes

@arminru arminru arminru approved these changes

@yurishkuro yurishkuro Awaiting requested review from yurishkuro

Assignees
No one assigned
Labels
area:api Cross language API specification issue area:error-reporting Related to error reporting area:semantic-conventions Related to semantic conventions release:required-for-ga Must be resolved before GA release, or nice to have before GA spec:trace Related to the specification/trace directory
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Oberon00 @bogdandrutu @carlosalberto @mwear @iNikem @arminru