Add specs on DistributedContext and propagation. #97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
songy23
requested review from
AloisReitbauer,
bogdandrutu,
c24t,
carlosalberto,
iredelmeier,
reyang,
SergeyKanzhelev,
tedsuo and
yurishkuro
as code owners
songy23
force-pushed
the
distributedcontext-2
branch
from
e4d9179
to
7291575
Compare
reyang
reviewed
Jun 10, 2019
| The order of entries is not significant. The iterator MUST not modify the underlying collection of | ||
| entries in this `DistributedContext`. | ||
|
|
||
| ## GetEntryValue |
There was a problem hiding this comment.
Should this be GetEntry? GetEntryValue seems to return the EntryValue which doesn't include the EntryMetadata.
DistributedContext.GetEntry('name').EntryMetadata
DistributedContext.GetEntry('name').EntryValue
There was a problem hiding this comment.
The operations are from Java APIs (https:/open-telemetry/opentelemetry-java/blob/master/api/src/main/java/io/opentelemetry/distributedcontext/DistributedContext.java) and currently there isn't an API GetEntry. I think it makes sense to have this GetEntry API that looks up entries by name - would like to hear others' opinions.
There was a problem hiding this comment.
Please file an issue with suggestion of a better name.
reyang
reviewed
Jun 10, 2019
reyang
reviewed
Jun 10, 2019
mayurkale22
reviewed
Jun 10, 2019
songy23
force-pushed
the
distributedcontext-2
branch
from
c91b83d
to
90a08e8
Compare
SergeyKanzhelev
approved these changes
Jun 11, 2019
Oberon00
reviewed
Jun 11, 2019
| @@ -2,6 +2,12 @@ | |||
| An `Entry` is used to label anything that is associated | |||
| with a specific operation, such as an HTTP request. | |||
|
|
|||
| `DistributedContext` is an abstract data type that represents collection of entries. | |||
| i.e., each key is associated with exactly one value. `DistributedContext` is serializable, | |||
There was a problem hiding this comment.
What is meant by key? It's not defined here when reading top to bottom. If it's what I think, then I would write: "DistributedContext is an abstract data type that maps EntryKeys to Entry objects."
There was a problem hiding this comment.
Rephrased with Sergey's suggestion.
Oberon00
reviewed
Jun 11, 2019
songy23
force-pushed
the
distributedcontext-2
branch
from
4b2b5a9
to
2a569ab
Compare
songy23
force-pushed
the
distributedcontext-2
branch
from
bd15397
to
3177d3f
Compare
|
Thanks for all the suggestions (really like the |
songy23
force-pushed
the
distributedcontext-2
branch
from
bcf2423
to
dfd2c8d
Compare
freeformz
reviewed
Jun 11, 2019
SergeyKanzhelev
pushed a commit
to SergeyKanzhelev/opentelemetry-specification
that referenced
this pull request
Feb 18, 2020
* Add specs on DistributedContext and propagation. * Clarify DistributedContext only includes entries. * Fix typos. * Apply suggestions. * Copy the description to terminology. * Example on propagation across boundaries.
TuckTuckFloof
pushed a commit
to TuckTuckFloof/opentelemetry-specification
that referenced
this pull request
Oct 15, 2020
rockb1017
pushed a commit
to rockb1017/opentelemetry-specification
that referenced
this pull request
Nov 18, 2021
* Remove RELEASING.md requirement * Apply PR suggestions * Make RELEASING.md optional * Removed unnecessary line * Update specification/repository.md Co-authored-by: Tyler Yahn <[email protected]> Co-authored-by: Tyler Yahn <[email protected]>
carlosalberto
pushed a commit
to carlosalberto/opentelemetry-specification
that referenced
this pull request
Oct 21, 2024
* Define Log Data model This is a proposal of a data model and semantic conventions that allow to represent logs from various sources: application log files, machine generated events, system logs, etc. Existing log formats can be unambiguously mapped to this data model. Reverse mapping from this data model is also possible to the extent that the target log format has equivalent capabilities. The purpose of the data model is to have a common understanding of what a log record is, what data needs to be recorded, transferred, stored and interpreted by a logging system. * Move content from Google Doc to markdown here * Address PR comments * Add Google Cloud Logging mapping * Address PR comments * Resolve Open Questions * Add ECS mapping * Address PR comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #41.
Most are a copy-and-paste from https:/census-instrumentation/opencensus-specs/blob/master/tags/TagMap.md#tagmap by renaming
Tag->EntryandTagMap->DistributedContext./cc @c24t @dinooliva @mayurkale22 @rghetia