Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OTel Collector Security Best Practices to OTel Docs Site #3479

Open
mjingle opened this issue Nov 2, 2023 · 11 comments
Open

Add OTel Collector Security Best Practices to OTel Docs Site #3479

mjingle opened this issue Nov 2, 2023 · 11 comments

Comments

@mjingle
Copy link
Contributor

mjingle commented Nov 2, 2023

Desired feature or idea:

The OTel Collector repo contains a Security Best Practices document. This information is very useful and should be included in the OTel Docs site rather than hidden in a repo file.

Including this information is helpful in that it sets expectations, gives an opinion, and provides important security information to OTel Collector users.

Additional context:

I know the file itself is written with a repository lens, for example with mentions of specific issues, so depending on preference, some editorial work may be required before publishing.

Suggestion: to reduce maintenance, the repository file could be linked into the OTel docs site, so whenever the repository file is updated, the website version is also updated.

@cartermp
Copy link
Contributor

cartermp commented Nov 2, 2023

Great idea - we should definitely have this documented on the site.

@chalin
Copy link
Contributor

chalin commented Nov 2, 2023

I'd rather not bring in another submodule if we can, especially for a single page. Would it be conceivable to have the page reside in this repo?

@cartermp
Copy link
Contributor

cartermp commented Nov 2, 2023

I'd much prefer that, yes. @open-telemetry/collector-approvers any thoughts?

@mx-psi
Copy link
Member

mx-psi commented Nov 3, 2023

We discussed this previously, I think my comment on #3227 (comment) still stands, IMO we should split the doc in two and have the user-focused part on the opentelemetry.io page

@mjingle
Copy link
Contributor Author

mjingle commented Nov 7, 2023

To be clear, my suggestion to wire repos together is very much optional and intended to address potential concerns with maintainers keeping documentation up to date. I've encountered different preferences and solutions, but I totally understand the preference for less submodules.

I'm excited to see positive reception for this information to be in the public docs! Please let me know if there's anything I can do to keep moving this forward.

@svrnm
Copy link
Member

svrnm commented Nov 8, 2023

@mjingle following @mx-psi's comment I think a good starting point would be taking a look at the current security documentation and extract what is user-facing and bringing it into a PR for the website.

@jpkrohling
Copy link
Member

I agree that the end user part of the linked documentation should be placed exclusively under opentelemetry.io. The current file in the repository could link to the website while keeping the advice targeted to component developers.

@theletterf
Copy link
Member

@mjingle Could you advance with the draft?

@mx-psi mx-psi removed the stale label Jul 31, 2024
@mx-psi
Copy link
Member

mx-psi commented Jul 31, 2024

It would be nice to have this completed for the Collector v1 distro. I see this as a basic part of how to setup your Collector and think this should be documented when this happens, so I have added it to the Collector v1 project board

@svrnm
Copy link
Member

svrnm commented Aug 1, 2024

@mjingle do you have time/bandwidth to work on this?

@tiffany76
Copy link
Contributor

I've messaged @mjingle about this issue and to let her know I'm going to take over so we can get security documentation in place for v1.0. Hope to put up a fresh PR this week. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Status: Changes Requested
Development

No branches or pull requests

8 participants