Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review visualizations for dark/light mode compatibility #5438

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

SusanGithaigaN
Copy link

This pr resolves issue #5361 and adjusts the background color of the visualizations, ensuring they adapt to both light and dark modes. The overall color scheme and theme remain unchanged.

##Demo

Review.visualizations.for.dark_light.mode.compatibility.5361.webm

@SusanGithaigaN SusanGithaigaN requested a review from a team as a code owner October 18, 2024 13:14
@opentelemetrybot opentelemetrybot requested review from a team and TylerHelmuth and removed request for a team October 18, 2024 13:14
@SusanGithaigaN
Copy link
Author

@chalin, @svrnm, I have implemented the changes you recommended.

@svrnm
Copy link
Member

svrnm commented Oct 18, 2024

thanks, a few comments:

@opentelemetrybot opentelemetrybot requested a review from a team October 18, 2024 19:03
@SusanGithaigaN
Copy link
Author

thanks, a few comments:

@svrnm, I have implemented the changes you recommended.
I'm now working on the dedicated pr for the image on the instrumentation scope page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

2 participants