-
Notifications
You must be signed in to change notification settings - Fork 164
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
profiles/follow up: consistent time format #253
Comments
cc @open-telemetry/profiling-maintainers @open-telemetry/profiling-approvers |
Comment from the OTel maintainer meeting: could / should this be moved to a comment on the current Profiling PR in the OTLP repository? |
This issue is linked in open-telemetry/opentelemetry-proto#534 (comment). As this particular issue is relevant to the specification, I did open the issue in this repository. |
Addressed in open-telemetry/opentelemetry-proto@f5b5897 |
Closing issue as resolved with open-telemetry/opentelemetry-proto@f5b5897. |
This is a follow up for #239 (comment) around the request for a consistent time precision:
In
ProfileContainer
there arestart_time_unix_nano
andend_time_unix_nano
. Should we have the same precision withtimestamps
inSample
and also usens
instead ofms
?oteps/text/profiles/0239-profiles-data-model.md
Lines 553 to 555 in dc619df
With
Profile.time_nanos
there is another timestamp in the message that uses nanosecond precision.The text was updated successfully, but these errors were encountered: