Remove SamplingHint from the Sampling otep #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bogdan Drutu <[email protected]>
bogdandrutu
requested review from
AloisReitbauer,
c24t,
carlosalberto,
iredelmeier,
jmacd,
reyang,
SergeyKanzhelev,
songy23,
tedsuo,
tigrannajaryan and
yurishkuro
as code owners
c24t
approved these changes
Jan 14, 2020
|
As an author I think it is easier to modify that otep, and also is not a change that was documented in the specs. |
This was referenced Jan 22, 2020
carlosalberto
approved these changes
Jan 25, 2020
|
@open-telemetry/specs-approvers please review, we need couple more reviews to merge this |
yurishkuro
approved these changes
Jan 28, 2020
jmacd
approved these changes
Jan 28, 2020
jkwatson
reviewed
Jan 28, 2020
jkwatson
reviewed
Jan 28, 2020
Co-Authored-By: John Watson <[email protected]>
Co-Authored-By: John Watson <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main motivation is that we did not proved the necessity of the SamplinHint well enough, and we can always add this in the future (applying the principal of a minimal API surface).