Improve visibility of used spec version in the semconv repo #558
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
arminru
approved these changes
Nov 23, 2023
arminru
reviewed
Nov 23, 2023
arminru
reviewed
Nov 23, 2023
arminru
added
the
editorial
Co-authored-by: Armin Ruech <[email protected]>
pyohannes
reviewed
Nov 24, 2023
pyohannes
approved these changes
Nov 24, 2023
pyohannes
pushed a commit
to pyohannes/semantic-conventions
that referenced
this pull request
Jan 17, 2024
…emetry#558) Co-authored-by: Armin Ruech <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #473 there was some confusion and back and forth regarding links to the specification repo. The confusion was about if links to the spec repo should point to
mainor to a specific tag.Today, we don't have any mention in
CONTRIBUTING.mdthat links to the spec should point to a tag. Also, it is not clear which version of the spec this repo is targeting. We only have this text in the root readme:Which can be easily missed since it's not obvious at first sight.
To improve things, I propose in this PR:
CONTRIBUTING.mdthat links to the spec should point to the current used spec versionupdate_specification_version.shis executed