-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[test]: e2e tests #47
Comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
#36 installs some seemingly useless devDependencies:
and
These are here because our integration testing writes actual files to the
/create
package root, therefore eslint import plugin is able to resolve them in/create/node_modules
. This is not ideal. Tests which rely on the scaffolded package's node_modules should run e2e in an isolated temp dir that's not affected by create's node_modules, or in a virtual filesystem where deps are stubbed.Originally posted by @bennypowers in #36 (comment)
The text was updated successfully, but these errors were encountered: