Fix #422: Add "last modified" line on cover page #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a proof-of-concept: * Introduce parameter "last.modified" for FO and XHTML by default it's empty * Introduce a "last.modified" key in language file (currently en ATM) * When the cover page is created, only add "Last modified" line when $last.modified != ''. Currently, the parameter $last.modified is used "as-is"; it will be included in the respective line no matter if it's a date or not. However, if it's a date, it is currently inconsistent with the publication date. That date is created from this line: <date><?dbtimestamp format="B d, Y"?></date> In other words, to make both dates to be consistent, the last modified date needs to be transformed into the format of the PI inside <date>.
tomschr
added
format-html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proof-of-concept and a draft ATM. It contains the following changes:
last.modifiedfor FO and XHTML, by default emptylast.modifiedkey in language file (currently only en ATM)Currently, the parameter $last.modified is used "as-is"; it is included in the respective line no matter if it's a date or not.
However, when a date is passed, it is currently inconsistent with the publication date. This looks like this (English):
Publication Date: October 29, 2020
Last modified: 2020-10-01
That first date is created from this line:
In other words, to make both dates consistent, the last modified date needs to be transformed into the format of the PI inside
<date>.We need to decide if we want a minimal solution first and improve it later, or, if we want to make it more consistent.