Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed DecoderConvBock typo in encdec.py and conditioners.py #24

Closed
wants to merge 2 commits into from

Conversation

Jovonni
Copy link

@Jovonni Jovonni commented May 2, 2020

DecoderConvBock is mispelled in several places in the code:

For example:

class DecoderConvBock(nn.Module):

and

self.cond = DecoderConvBock(self.width, self.width, down_t, stride_t, **block_kwargs, zero_out=zero_out, res_scale=res_scale)

But EncoderConvBlock is correctly spelled

@Jovonni
Copy link
Author

Jovonni commented May 2, 2020

i've searched, and no other DecoderConvBock typos

@prafullasd
Copy link
Collaborator

Thanks for flagging this!
Merging as is will break loading of model checkpoint though, as pytorch will have formatted the keys based on the old class names. If we change both the code and the checkpoints, it'll break the code for people who downloaded the old checkpoints.
It might be easier to keep the typo in this case

@prafullasd prafullasd self-assigned this May 5, 2020
@prafullasd prafullasd closed this May 7, 2020
@dhurtigkth dhurtigkth mentioned this pull request May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants