Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide proper first-party oauth server by API #40

Closed
10 tasks done
opatut opened this issue Feb 19, 2021 · 1 comment
Closed
10 tasks done

Provide proper first-party oauth server by API #40

opatut opened this issue Feb 19, 2021 · 1 comment

Comments

@opatut
Copy link
Member

opatut commented Feb 19, 2021

I am following RFC8252 and security-topics to suggest and implement a change in the authorization schemes for improved security across the whole portal system. The design goal is to follow the above specs to reduce the attack surface on the web application (frontend) by using standardized, documented and well-known best practices.

This involves the following steps:

  • Cookie (http-only) based sessions for transaction management
  • Implement authorization code flow
  • Minimal HTML rendering for login
  • Small CSS style and frame layout to make it look first-party
  • Add support for (and enforce the use of) PKCE
  • Registration form
  • Password reset
  • Account email verification pages
  • Move new react frontend to auth code flow
  • Harden react flow with PKCE, according to {RFC8252]

Afterwards, these topics will await us

I know this sounds like a lot but I think it is manageable and it will let me sleep better at night ;)

Yes, this removes some features (login & registration forms, email verification) from the frontend code and moves it to the server, but it would have to be reimplemented anyway in React, and this way it's actually easier to build, extend, and control. Plus it's frontend independent, so it will integrate with any other app that somebody might build in the future (e.g. native apps etc). I think it's a good thing.

@opatut opatut changed the title Provider proper first-party oauth server by API Provide proper first-party oauth server by API Feb 20, 2021
@opatut opatut added this to the v0.2 milestone Apr 28, 2021
@opatut
Copy link
Member Author

opatut commented Apr 30, 2021

I've created new tickets for the remaining tasks, so this can be closed.

@opatut opatut closed this as completed Apr 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant