Input: uinput - switch to using for_each_set_bit()

Use for_each_set_bit to check for set bits in bitmap as it is more efficient and compact. Signed-off-by: Anshul Garg <[email protected]> Signed-off-by: Dmitry Torokhov <[email protected]>
openbmc · Jul 9, 2015 · b6d3096 · b6d3096
1 parent 948cea1
commit b6d3096
Showing 1 changed file with 2 additions and 4 deletions.
diff --git a/drivers/input/misc/uinput.c b/drivers/input/misc/uinput.c
@@ -320,10 +320,8 @@ static int uinput_validate_absbits(struct input_dev *dev)
  * Check if absmin/absmax/absfuzz/absflat are sane.
  */
 
- for (cnt = 0; cnt < ABS_CNT; cnt++) {
+ for_each_set_bit(cnt, dev->absbit, ABS_CNT) {
  int min, max;
- if (!test_bit(cnt, dev->absbit))
- continue;
 
  min = input_abs_get_min(dev, cnt);
  max = input_abs_get_max(dev, cnt);
@@ -416,7 +414,7 @@ static int uinput_setup_device(struct uinput_device *udev,
  dev->id.product = user_dev->id.product;
  dev->id.version = user_dev->id.version;
 
- for (i = 0; i < ABS_CNT; i++) {
+ for_each_set_bit(i, dev->absbit, ABS_CNT) {
  input_abs_set_max(dev, i, user_dev->absmax[i]);
  input_abs_set_min(dev, i, user_dev->absmin[i]);
  input_abs_set_fuzz(dev, i, user_dev->absfuzz[i]);