Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecation of alias support for gNMI 0.9.0 #126

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

earies
Copy link

@earies earies commented Jul 7, 2022

Alias support in gNMI was removed from the specification however the .proto was never updated to reflect these changes. This PR addresses removal (deprecation) of alias support in the proto IDL for client/server implementations.

References:

- Removal of alias per openconfig/reference#148
- Regeneration of stubs
@earies
Copy link
Author

earies commented Jul 8, 2022

@gcsl @robshakir PTAL

@hellt
Copy link
Contributor

hellt commented Jan 25, 2023

this is a considerable change which backfired at us since the published go package to this date is unversioned, which makes it quite hard to pin dependencies.

Currently, I see that the generated stubs are wiped from aliases entirely (not deprecated, but moved to reserved). https://pkg.go.dev/github.com/openconfig/[email protected]/proto/gnmi#SubscriptionList

I think we really need to start tagging this repo with semver tags matching the spec version, otherwise downstream users are doomed to have issues with pinning dependencies and understanding which generated collection corresponds to which gnmi version.

@hellt
Copy link
Contributor

hellt commented Jan 25, 2023

@marcushines @robshakir this commit 480bf53#diff-49fc5824be3cfb8d64321cc64142f0568a3039a55da00d2aaed8fd766369854c changed gnmi.proto and generated stubs in a non-backwards compatible way without bumping the service version.

Currently, the statement outlined in the https:/openconfig/reference/blob/master/rpc/gnmi/gnmi-specification.md#grpc-network-management-interface-gnmi header renders itself false, as the service proto and stubs do not conform to the 0.8.x version

@hellt
Copy link
Contributor

hellt commented Jan 27, 2023

@earies I see that @marcushines just released 0.9.0, and one thing that is quite different from this proposal is that alias and use_aliases were not deprecated, but moved to reserved fields of the protos.
This effectively makes those fields absent from the generated stubs entirely...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants