-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support confirmed commit in gNMI SetRequest #197
Comments
kidiyoor
added a commit
to kidiyoor/reference
that referenced
this issue
Oct 11, 2023
Updating the proposal as per the Proposal-1 of in [openconfig#197](openconfig#197)
This was referenced Oct 11, 2023
Fixed in #196 and openconfig/gnmi#155 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
A PR #196 was created with an initial proposal to initiate discussion to add confirmed commit support. From the feedbacks received we have drafted a new proposal, creating this issue to continue discussion on the new proposal.
The proposed proto has a subset of confirmed commit functionality as defined in NETCONF protocol(RFC6241). The proposal has a healthy disregard to few functionality defined in the RFC with the intention that most of the gRPC API clients are going to be automated systems and the proto should facilitate a simpler implementation of client workflows and server implementation.
The server can be viewed as a singleton resource, at any given point in time there can be only one commit active. This commit can be either confirmed or canceled before a new commit can begin. Client is expected to provide full configuration during the commit request, the commit cannot be amended once issued.
With these in mind, below are the two proposals-
Proposal-1
Proto update PR: openconfig/gnmi#155
Reference/README update PR: #196
Above spec limits the transactions to below three transactions-
Note: It doesn’t allow a new commit along with confirmation of previous commit.
Handing of Proposal-1 is explained here.
Alternate discussion options:
Proposal-2
Handing of Proposal-2 is explained here.
Allows below transactions-
Open Questions
The text was updated successfully, but these errors were encountered: