do not register sha384 by default #97
Draft
+15
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thaJeztah
requested review from
AkihiroSuda,
dmcgowan,
stevvooe and
vbatts
as code owners
thaJeztah
force-pushed
the
remove_SHA384_default
branch
2 times, most recently
from
e40c566
to
5dee832
Compare
AkihiroSuda
reviewed
Jan 25, 2024
sha.go
Outdated
| @@ -18,6 +18,5 @@ const ( | |||
|
|
|||
| func init() { | |||
| RegisterAlgorithm(SHA256, crypto.SHA256) | |||
| RegisterAlgorithm(SHA384, crypto.SHA384) | |||
There was a problem hiding this comment.
This is a breaking change, do we need to bump up the major version?
There was a problem hiding this comment.
Hm.. good question. Before 084376b (not yet part of a release), neither of them would work out of the box unless the algorithms were registered, so perhaps some wiggle room, but you may be right that it could be a v2 worth if we decide to remove.
There was a problem hiding this comment.
(honestly not sure why SHA384 and SHA512 ever made it in at all, but 🤷♂️)
|
Let me move this one to draft; I rebased #98 to not depend on this PR. |
stevvooe
approved these changes
Apr 22, 2024
The SHA-384 algorithm is not documented in the OCI image-spec ([1], [2]), and is not encouraged to be used. Commit 084376b registered all algorithms by default, but also included SHA-384. This patch disables SHA-384 by default, to discourage its use. [1]: https:/opencontainers/image-spec/blob/v1.0.2/descriptor.md#digests [2]: https:/opencontainers/image-spec/blob/v1.0.2/descriptor.md#registered-algorithms Signed-off-by: Sebastiaan van Stijn <[email protected]>
thaJeztah
force-pushed
the
remove_SHA384_default
branch
from
5dee832
to
dead9ba
Compare
|
I rebased this, but kept it in draft for now, pending the discussion on this being a breaking change (and warranting a v2 of this module) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related:
The SHA-384 algorithm is not documented in the OCI image-spec (1, 2), and is not encouraged to be used. Commit 084376b registered all algorithms by default, but also included SHA-384.
This patch disables SHA-384 by default, to discourage its use.