Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: amend updating signatures in client and workflow #7579

Merged
merged 9 commits into from
Sep 9, 2024

Conversation

Nil20
Copy link
Collaborator

@Nil20 Nil20 commented Sep 4, 2024

  • Updating the forms to be review forms, to track the values of a declaration. Since we keep the signatures in review section of draftData when we update the signature.
  • If a presignedUrl is available for a signature(which might have been provided by a field agent), then when a registrar want to update a record and calls the /update-record endpoint, we convert the presignedUrl to the minioUri before saving it in the task of the bundle.

This comment has been minimized.

@Nil20
Copy link
Collaborator Author

Nil20 commented Sep 4, 2024

This would be the current look.

image


function getMinioUri(url: string) {
const parsedUrl = new URL(url)
const filePath = parsedUrl.pathname
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good solution 👍

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we move this function to attachments and call it something like

function getCanonicalAttachmentURL(presignedOrCanonical: string) {
  if(presignedOrCanonical) {
    return <path name>
  }
  return presignedOrCanonical
}

please?

@Nil20 Nil20 changed the title fix: update using review form instead of register form for different action (e.g. - register, validate) fix: amend updating signatures in client and workflow Sep 9, 2024
@Zangetsu101 Zangetsu101 merged commit 1e9318e into develop Sep 9, 2024
22 checks passed
github-actions bot pushed a commit that referenced this pull request Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants