Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Action Menu #7633

Open
wants to merge 71 commits into
base: develop
Choose a base branch
from
Open

feat: Action Menu #7633

wants to merge 71 commits into from

Conversation

jamil314
Copy link
Collaborator

@jamil314 jamil314 commented Sep 19, 2024

Country config pr for missing translations
Farajaland pr with e2e changes
#7390

@jamil314 jamil314 added this to the v1.7.0 milestone Sep 19, 2024

This comment has been minimized.

@Zangetsu101
Copy link
Collaborator

Can we create an API similar to this https://ui.shadcn.com/docs/components/dropdown-menu? It brings way more flexibility in it's usage.
I'm pretty sure we can build our ToggleMenu component using the dropdown-menu quite easily which just shows that it's a better abstraction.
@rikukissa @naftis What do you think? Are we willing to move towards these now? Using radix for example could improve our accessibility index quite a bit
Even still if we can just build a similar API as the dropdown-menu, it would still be a plus in my book

@naftis
Copy link
Collaborator

naftis commented Sep 24, 2024

@Zangetsu101 About the abstraction; good idea, and yes please. We're already using something similar for example in ListReview and Frame:

<ListReview>
	<ListReview.Header label="FIELD" value="INPUT" />
	<ListReview.Row label="Firstname(s)" value="Peter Jonathan" actions={LinkExample} />
	<ListReview.Row label="Lastname" value="Jones" actions={LinkExample} />
</ListReview>

packages/client/src/views/RecordAudit/ActionMenu.tsx Outdated Show resolved Hide resolved
packages/client/src/views/RecordAudit/ActionMenu.tsx Outdated Show resolved Hide resolved
packages/client/src/views/RecordAudit/ActionMenu.tsx Outdated Show resolved Hide resolved
packages/client/src/views/RecordAudit/ActionMenu.tsx Outdated Show resolved Hide resolved
packages/components/src/Dropdown/Dropdown.tsx Outdated Show resolved Hide resolved
packages/components/src/Dropdown/DropdownContext.tsx Outdated Show resolved Hide resolved
packages/components/src/ToggleMenu/ToggleMenu.tsx Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants