Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to setuptools_scm instead of versioneer #877

Merged
merged 2 commits into from
Feb 27, 2020
Merged

Conversation

omad
Copy link
Member

@omad omad commented Feb 26, 2020

Versioneer is old, unsupported, and produces bogus
version numbers which can lead to unstable versions
being accidentally installed.

Reason for this pull request

See #871

Versioneer is old, unsupported, and produces bogus
version numbers which can lead to unstable versions
being accidentally installed.
@codecov
Copy link

codecov bot commented Feb 26, 2020

Codecov Report

Merging #877 into develop will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #877      +/-   ##
===========================================
- Coverage    89.93%   89.92%   -0.01%     
===========================================
  Files           95       94       -1     
  Lines         9386     9383       -3     
===========================================
- Hits          8441     8438       -3     
  Misses         945      945              

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1cf3cea...63453ad. Read the comment docs.

@omad omad requested a review from Kirill888 February 26, 2020 23:27
Copy link
Member

@Kirill888 Kirill888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🏆

@omad omad merged commit 03149ec into develop Feb 27, 2020
@delete-merged-branch delete-merged-branch bot deleted the remove_versioneer branch February 27, 2020 00:19
@snowman2
Copy link
Contributor

We ran into this issue today: pypa/pip#7778

I am wondering if it is possible to use a pyproject.toml instead of defining setup_requires for this?

@omad
Copy link
Member Author

omad commented Feb 27, 2020

That should be possible @snowman2 , I'll open a new PR soon with the change.

@omad omad mentioned this pull request Feb 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect versioning of development packages
3 participants