Add "objectstore.umask" configuration option for file/directory creation #566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This defaults to 0077 to preserve the existing behaviour. It can be set to 0027 to allow users in the same group to backup the token files. It does not attempt to modify the process umask (because this is a library) so it can only apply in addition to whatever umask the process has. Fixes opendnssec#560 after opendnssec#40 restricted all new files to the current user.
|
Thanks for the PR! I performed a first review, looks good at first glance, requesting a review from @halderen and asking him to merge if he also thinks the code is OK. |
|
Watch out for the |
|
Nice contribution. Although most times the shell umask is used, I could see the this be overridden. |
nomis
added a commit
to nomis/SoftHSMv2
that referenced
this pull request
Aug 16, 2022
The "true" in the call to Generation::create() in OSToken::OSToken() is used as the umask when it's supposed to be the isToken value (opendnssec#566). Remove the default value from isToken because it's dangerous and there are only two callers. Explicitly pass "true" and "false" for isToken. Failing to consider this a token generation file means that the value is never refreshed for read-only operations. All objects are reloaded from disk every time one of them is refreshed. List operations take a long time because all of the objects are re-read for each object. Fixes opendnssec#680.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This defaults to 0077 to preserve the existing behaviour. It can be set to
0027 to allow users in the same group to backup the token files.
It does not attempt to modify the process umask (because this is a library)
so it can only apply in addition to whatever umask the process has.
Fixes #560 after #40 restricted all new files to the current user.