Error handling in seachest probe #198
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
satbirchhikara
previously approved these changes
Jan 31, 2019
Codecov Report
@@ Coverage Diff @@
## master #198 +/- ##
==========================================
- Coverage 51.21% 51.18% -0.03%
==========================================
Files 43 43
Lines 1722 1723 +1
==========================================
Hits 882 882
- Misses 777 778 +1
Partials 63 63
Continue to review full report at Codecov.
|
If seachest probe is unable to fetch details, i.e reports an error, FillDiskDetails() is returned without further processing Signed-off-by: Akhil Mohan <[email protected]>
akhilerm
force-pushed
the
privilege-issue
branch
from
8b9696e
to
5ba2953
Compare
kmova
approved these changes
Jan 31, 2019
|
This PR fixes issue #194 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If NDM is run in unprivileged mode, Seachest probe was causing the pod into
CrashLoopBackOffstate. This was because Seachest was having insufficient permissions to fetch the details. The PR aborts filling the details by Seachest probe if its not able to get thedriveInfopointer.