fix (yaml): changed pull policy and upgrade strategy #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ImagePullPolicy changed from Always to IfNotPresent Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
Signed-off-by: Akhil Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #200 +/- ##
==========================================
- Coverage 51.1% 50.65% -0.46%
==========================================
Files 43 43
Lines 1769 1769
==========================================
- Hits 904 896 -8
- Misses 800 806 +6
- Partials 65 67 +2
Continue to review full report at Codecov.
|
prateekpandey14
approved these changes
Feb 11, 2019
There was a problem hiding this comment.
Lgtm... @akhilerm can you update the Rollingupdate change to openebs-operator file as well ..... thanks
satbirchhikara
approved these changes
Feb 11, 2019
kmova
approved these changes
Feb 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed
ImagePullPolicytoIfNotPresent. Earlier, during integration testing the old image from docker-hub was pulled which overwrite the newly built images. This resulted in integration tests being performed on the old image and also the old image was retagged and pushed. With the change, only the newly built image will be used.The update strategy of Daemonset is now set to RollingUpdate, so that the new image will be applied without manual deletion.