Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: error 500 lms/dashboard after applying ecommerse coupon #4003

Merged

Conversation

DmytroAlipov
Copy link
Contributor

Description

Steps to Reproduce:

  • Login by the user with staff rights
  • During purchase click on the link "Click here to purchase multiple seats in this course"
  • Confirm and pay
  • Activate the course with one of the coupons sent to your email
  • Open /dashboard page
dashboard

The issue was that the date-time also included milliseconds, which is not acceptable for converting the date and time into the required format.

ValueError: time data '2033-06-25T11:40:12.267999Z' does not match format '%Y-%m-%dT%H:%M:%SZ'

@DmytroAlipov DmytroAlipov requested a review from a team as a code owner July 12, 2023 18:44
@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Jul 12, 2023
@openedx-webhooks
Copy link

openedx-webhooks commented Jul 12, 2023

Thanks for the pull request, @DmytroAlipov! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@DmytroAlipov DmytroAlipov force-pushed the fix-500-after-applying-coupon-master branch 2 times, most recently from 2583b6e to c4e8544 Compare July 13, 2023 10:36
@mphilbrick211
Copy link

Hi @openedx/revenue-squad! Friendly ping on this!

@mphilbrick211 mphilbrick211 added the waiting for eng review PR is ready for review. Review and merge it, or suggest changes. label Aug 7, 2023
@mphilbrick211
Copy link

Hi @openedx/revenue-squad! Friendly ping on this!

Hi @openedx/revenue-squad! Could we get an ETA on getting this reviewed?

@DmytroAlipov
Copy link
Contributor Author

@mphilbrick211
Friendly ping. Who could merge this MR, since all the others have already been merged

@zubair-ce07 zubair-ce07 self-assigned this Apr 8, 2024
@zubair-ce07
Copy link
Contributor

@mphilbrick211 @DmytroAlipov I'm looking into it. Will try to approve it asap.
Thanks

@zubair-ce07 zubair-ce07 merged commit fe47e90 into openedx:master Apr 8, 2024
8 checks passed
@openedx-webhooks
Copy link

@DmytroAlipov 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@DmytroAlipov
Copy link
Contributor Author

@zubair-ce07 Thank you very much!

@DmytroAlipov DmytroAlipov deleted the fix-500-after-applying-coupon-master branch April 8, 2024 14:47
Danyal-Faheem pushed a commit to Danyal-Faheem/ecommerce that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
open-source-contribution PR author is not from Axim or 2U waiting for eng review PR is ready for review. Review and merge it, or suggest changes.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants