Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add python38->311->312 details to edx-sandbox readme #34632

Merged
merged 1 commit into from
Apr 30, 2024

Conversation

kdmccormick
Copy link
Member

@feanil , this summarizes what we talked about after maintenance WG today so we don't forget it. Hopefully it's also helpful for operators and the Redwood release note authors.

Review tip: don't try to read the diff. Just read the rendered doc before and after.

Comment on lines 62 to 65
* BREAKING CHANGE: SciPy is upgraded from 1.7.3 to 1.10.1

Support windows
***************
* Please refer to the `SciPy release notes <https://docs.scipy.org/doc/scipy/release.html>`_ for breaking changes.
* This upgrade prepares edx-sandbox for the Python 3.12 update in Sumac.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@feanil is there anything about the SciPy upgrade you wanted to call out here, or is linking to the release notes sufficient?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is sufficient, there are a lot of different specific changes based on what you are using so I don't think capturing them here makes sense.

Copy link
Contributor

@feanil feanil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good, added a couple of suggestions because Numpy will also be getting upgraded. I'm currently testing with 1.24.4 which is the newest version with 3.8 support.

Comment on lines 62 to 65
* BREAKING CHANGE: SciPy is upgraded from 1.7.3 to 1.10.1

Support windows
***************
* Please refer to the `SciPy release notes <https://docs.scipy.org/doc/scipy/release.html>`_ for breaking changes.
* This upgrade prepares edx-sandbox for the Python 3.12 update in Sumac.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link is sufficient, there are a lot of different specific changes based on what you are using so I don't think capturing them here makes sense.

environment without breaking changes.
* Frozen at the time of the Redwood release
* Supports Python 3.8 and Python 3.11
* BREAKING CHANGE: SciPy is upgraded from 1.7.3 to 1.10.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* BREAKING CHANGE: SciPy is upgraded from 1.7.3 to 1.10.1
* BREAKING CHANGE: SciPy is upgraded from 1.7.3 to 1.10.1
* BREAKING CHANGE: Numpy is upgraded from 1.22.4 to 1.24.4


Support windows
***************
* Please refer to the `SciPy release notes <https://docs.scipy.org/doc/scipy/release.html>`_ for breaking changes.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
* Please refer to the `SciPy release notes <https://docs.scipy.org/doc/scipy/release.html>`_ for breaking changes.
* Please refer to the `Numpy release notes <https://numpy.org/doc/stable/release.html>`_ for breaking changes.

@kdmccormick kdmccormick force-pushed the kdmccormick/edx-sandbox-readme-python-upgrades branch from 505ab35 to 2743c4b Compare April 30, 2024 17:30
@kdmccormick kdmccormick force-pushed the kdmccormick/edx-sandbox-readme-python-upgrades branch from 2743c4b to 603d0b9 Compare April 30, 2024 17:35
@kdmccormick kdmccormick merged commit d4ca537 into master Apr 30, 2024
48 of 61 checks passed
@kdmccormick kdmccormick deleted the kdmccormick/edx-sandbox-readme-python-upgrades branch April 30, 2024 17:36
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX staging environment in preparation for a release to production.

@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

1 similar comment
@edx-pipeline-bot
Copy link
Contributor

2U Release Notice: This PR has been deployed to the edX production environment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants