-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soft delete collections #35496
Merged
Merged
Soft delete collections #35496
Commits on Sep 20, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 21393f1 - Browse repository at this point
Copy the full SHA 21393f1View commit details -
refactor: use collection usage_key as search document id
This change standardises the search document "id" to be a meilisearch ID generated from the usage key, for all types of indexed objects. This is important for collections so we can locate the collection document in the search index solely from the data provided by the LIBRARY_COLLECTION_DELETED event (library_key + collection_key), even if the collection has been deleted from the database.
Configuration menu - View commit details
-
Copy full SHA for f760c2b - Browse repository at this point
Copy the full SHA f760c2bView commit details -
refactor: avoid fetching more data than we have to.
* get_library_collection_usage_key and searchable_doc_tags_for_collection do not need a Collection object; the usage key can be created from the library_key and collection_key. * updated searchable_doc_for_collection to require the parts of the collection usage key + an optional collection. This allows us to identify the collection's search document from its usage key without requiring an existing Collection object (in case it's been deleted). Also removes the edge case for indexing Collections not associated with a ContentLibrary -- this won't ever really happen.
Configuration menu - View commit details
-
Copy full SHA for 0534550 - Browse repository at this point
Copy the full SHA 0534550View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9602c49 - Browse repository at this point
Copy the full SHA 9602c49View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8210d0e - Browse repository at this point
Copy the full SHA 8210d0eView commit details -
Configuration menu - View commit details
-
Copy full SHA for f15df7d - Browse repository at this point
Copy the full SHA f15df7dView commit details -
refactor: send CONTENT_OBJECT_ASSOCIATON_CHANGED on django model signals
so that added/removed collections are removed/re-added to component documents. Special case: When a collection is soft-deleted/restored, we detect this in the search index and update the collection's component documents directly, without a CONTENT_OBJECT_ASSOCIATON_CHANGED signal.
Configuration menu - View commit details
-
Copy full SHA for 494d1a7 - Browse repository at this point
Copy the full SHA 494d1a7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5a71333 - Browse repository at this point
Copy the full SHA 5a71333View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1a9f655 - Browse repository at this point
Copy the full SHA 1a9f655View commit details
Commits on Sep 24, 2024
-
Configuration menu - View commit details
-
Copy full SHA for a6b0ff0 - Browse repository at this point
Copy the full SHA a6b0ff0View commit details -
Configuration menu - View commit details
-
Copy full SHA for c1438c1 - Browse repository at this point
Copy the full SHA c1438c1View commit details
Commits on Sep 25, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e92f405 - Browse repository at this point
Copy the full SHA e92f405View commit details -
Configuration menu - View commit details
-
Copy full SHA for a54096e - Browse repository at this point
Copy the full SHA a54096eView commit details -
Configuration menu - View commit details
-
Copy full SHA for ea9493d - Browse repository at this point
Copy the full SHA ea9493dView commit details -
Configuration menu - View commit details
-
Copy full SHA for e30c4bd - Browse repository at this point
Copy the full SHA e30c4bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 01f8298 - Browse repository at this point
Copy the full SHA 01f8298View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.