Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement showPreferences flag in notification preferences #828

Merged
merged 2 commits into from
Jul 14, 2023

Conversation

awais-ansari
Copy link
Contributor

INF-952

  • Hide and show the notification preferences according to the showPreferences flag.

@codecov
Copy link

codecov bot commented Jul 13, 2023

Codecov Report

Patch coverage: 62.50% and project coverage change: +1.26 🎉

Comparison is base (c75dc86) 44.87% compared to head (13a7508) 46.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #828      +/-   ##
==========================================
+ Coverage   44.87%   46.13%   +1.26%     
==========================================
  Files         121      121              
  Lines        2525     2525              
  Branches      668      666       -2     
==========================================
+ Hits         1133     1165      +32     
+ Misses       1314     1284      -30     
+ Partials       78       76       -2     
Impacted Files Coverage Δ
src/account-settings/AccountSettingsPage.jsx 1.40% <0.00%> (-0.01%) ⬇️
src/index.jsx 0.00% <ø> (ø)
src/notification-preferences/data/reducers.js 93.33% <ø> (ø)
src/notification-preferences/data/thunks.js 12.96% <0.00%> (ø)
src/notification-preferences/messages.js 100.00% <ø> (ø)
src/account-settings/JumpNav.jsx 90.00% <100.00%> (ø)
src/notification-preferences/data/selectors.js 100.00% <100.00%> (ø)

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@awais-ansari awais-ansari merged commit a52ab17 into master Jul 14, 2023
7 checks passed
@awais-ansari awais-ansari deleted the aansari/INF-952 branch July 14, 2023 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants