Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Attempting to merge Master in to (Theseus) Replatforming #364

Conversation

grmartin
Copy link
Contributor

No description provided.

@grmartin grmartin requested a review from a team as a code owner January 19, 2024 15:18
Copy link

codecov bot commented Jan 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (2u/replatforming@a5c446b). Click here to learn what that means.

Additional details and impacted files
@@                 Coverage Diff                 @@
##             2u/replatforming     #364   +/-   ##
===================================================
  Coverage                    ?   63.58%           
===================================================
  Files                       ?       34           
  Lines                       ?      335           
  Branches                    ?       74           
===================================================
  Hits                        ?      213           
  Misses                      ?      115           
  Partials                    ?        7           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@julianajlk julianajlk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, might be helpful to add which commits from master you're merging for future reference!

@grmartin grmartin requested a review from pshiu January 25, 2024 15:43
Copy link
Contributor

@pshiu pshiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was really hard to see this given how much time has passed, but I think the only change to master from 2u/project-theseus and 2u/replatforming is just commit f545a5e to add the 2u/project-theseus branch to CI:

frontend-app-ecommerce % git log --oneline origin/master..origin/2u/replatforming 
a5c446b (origin/2u/replatforming, origin/2u/project-theseus) chore: Syncing 2u/project-theseus with master [2023-08-29] (#327)
f545a5e build: add 2u/project-theseus branch to run ci (#265)

We don't need f545a5e in master, so we may just want to close this PR & delete both branches, working from master from here on out.

@pshiu
Copy link
Contributor

pshiu commented Mar 14, 2024

Closing PR as no longer needed!

@pshiu pshiu closed this Mar 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants