-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: DataTable cells vertical alignment #376
base: open-release/quince.master
Are you sure you want to change the base?
fix: DataTable cells vertical alignment #376
Conversation
Thanks for the pull request, @Lunyachek! What's next?Please work through the following steps to get your changes ready for engineering review: 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. 🔘 Let us know that your PR is ready for review:Who will review my changes?This repository is currently unmaintained. To get help with finding a technical reviewer, tag the community contributions project manager for this PR in a comment and let them know that your changes are ready for review:
Where can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:
When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## open-release/quince.master #376 +/- ##
=============================================================
Coverage ? 61.53%
=============================================================
Files ? 34
Lines ? 325
Branches ? 69
=============================================================
Hits ? 200
Misses ? 118
Partials ? 7 ☔ View full report in Codecov by Sentry. |
This is backport form master - #375
Description
Our proposal is to remove the bottom margin from the
element in the first column of the table. This margin is causing the center alignment within the cell to break in our table. Attached below is a screenshot of the problem and a screenshot after the fix.
After fix