Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace @edx/paragon and @edx/frontend-build #257

Merged
merged 8 commits into from
Feb 21, 2024

Conversation

Mashal-m
Copy link
Contributor

@Mashal-m Mashal-m commented Dec 28, 2023

Part of openedx/axim-engineering#23

This replaces the @edx/paragon and @edx/frontend-build package.
Imports have been updated to use the same locations in the new package.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0ef53ed) 70.22% compared to head (01a9e83) 70.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #257   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          27       27           
  Lines         403      403           
  Branches       85       85           
=======================================
  Hits          283      283           
  Misses        119      119           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@justinhynes
Copy link
Contributor

HI @Mashal-m,

This doesn't look like it's had many changes in the past two weeks. Is this ready for review? Should this still be a draft PR?

@BilalQamar95 BilalQamar95 marked this pull request as ready for review February 9, 2024 13:16
@BilalQamar95
Copy link
Contributor

Hi @justinhynes, this PR is now ready for review

@jsnwesson
Copy link
Contributor

Thanks @BilalQamar95 ! I'll be adding this PR to be reviewed by the team for our next sprint.

@jsnwesson jsnwesson added waiting for eng review PR is ready for review. Review and merge it, or suggest changes. needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Feb 16, 2024
@jsnwesson
Copy link
Contributor

Since I had some time to look over this, I fixed a merge conflict that was going to be best handled by me. Everything else looked good in the original PR. I'll be merging and deploying next Tuesday!

@deborahgu
Copy link
Member

@Mashal-m or @BilalQamar95 could you resolve the package.json conflict again? I would do it myself but knowing what to choose out of the packages is the point of this PR and I'm not sure I would get it right.

@deborahgu deborahgu added the waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. label Feb 20, 2024
…ner-record into mashal-m/replace-edx/paragon-frontend-build
@deborahgu deborahgu merged commit 35bd64b into master Feb 21, 2024
8 checks passed
@deborahgu deborahgu deleted the mashal-m/replace-edx/paragon-frontend-build branch February 21, 2024 14:21
@deborahgu deborahgu removed waiting on author PR author needs to resolve review requests, answer questions, fix tests, etc. waiting for eng review PR is ready for review. Review and merge it, or suggest changes. needs maintainer attention Issue or PR specifically needs the attention of the maintainer. labels Feb 21, 2024
@BilalQamar95 BilalQamar95 self-assigned this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants