Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add a fluid container to allow for limiting the maximum width of the content [backport from master] #277

Conversation

Lunyachek
Copy link
Contributor

@Lunyachek Lunyachek commented Feb 7, 2024

This is backport from master #276

Our proposal is to add <div class="container-fluid"> inside the <main id="main-content"> block. This will allow limiting the maximum width of the content when necessary. Otherwise, the content will span the entire width of the page, as it would without this div.

Example screenshot width content max-width
Снимок экрана 2024-02-07 в 23 13 05

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Feb 7, 2024
@openedx-webhooks
Copy link

Thanks for the pull request, @Lunyachek! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

Copy link

codecov bot commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.60%. Comparing base (051a3b6) to head (5f95f71).

Additional details and impacted files
@@                     Coverage Diff                     @@
##           open-release/quince.master     #277   +/-   ##
===========================================================
  Coverage                       69.60%   69.60%           
===========================================================
  Files                              27       27           
  Lines                             408      408           
  Branches                           90       90           
===========================================================
  Hits                              284      284           
  Misses                            123      123           
  Partials                            1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mphilbrick211 mphilbrick211 added the backport PR backports a change from main to a named release. label Feb 8, 2024
@jsnwesson jsnwesson merged commit c3e2599 into openedx:open-release/quince.master Feb 26, 2024
7 checks passed
@openedx-webhooks
Copy link

@Lunyachek 🎉 Your pull request was merged! Please take a moment to answer a two question survey so we can improve your experience in the future.

@Lunyachek Lunyachek deleted the lunyachek/feat/add-fluid-container-quince branch February 26, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport PR backports a change from main to a named release. open-source-contribution PR author is not from Axim or 2U
Projects
Status: Done
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants