Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't generate frontend specific urls for the Learner Record MFE #105

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

justinhynes
Copy link
Contributor

@justinhynes justinhynes commented Oct 18, 2022

[APER-1975]

We're just going to generate links to the Credentials IDA and we will let the IDA figure out where the user should be directed to (either the LR MFE or the legacy frontend). This makes handlings URLs much easier if we just let the backend manage this work.

We're just going to generate links to the Credentials IDA and we will let the IDA figure out where the user should be directed to (either the LR MFE or the legacy frontend). This makes handlings URLs much easier if we just let the backend manage this work.
@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Base: 69.20% // Head: 69.20% // No change to project coverage 👍

Coverage data is based on head (f889856) compared to base (da03b19).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #105   +/-   ##
=======================================
  Coverage   69.20%   69.20%           
=======================================
  Files          14       14           
  Lines         276      276           
  Branches       63       63           
=======================================
  Hits          191      191           
  Misses         85       85           
Impacted Files Coverage Δ
.../components/ProgramRecord/ProgramRecordActions.jsx 69.23% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@justinhynes justinhynes marked this pull request as ready for review October 19, 2022 12:16
Copy link
Member

@MaxFrank13 MaxFrank13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@justinhynes justinhynes merged commit 180cb89 into master Oct 19, 2022
@justinhynes justinhynes deleted the jhynes/aper-1975_redirect branch October 19, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants