Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add env config handling in patch of webpack prod config #282

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

jsnwesson
Copy link
Contributor

@jsnwesson jsnwesson commented Feb 12, 2024

APER-2786

This is a follow-up to #275 to have Webpack Prod config use env.config.js for assigning NEW_RELIC_APP_ID and BASE_URL during the creation of two New Relic plugins.

This work is a temporary patch until we can add these changes to frontend-build and Learner Record migrates from using @edx/frontend-build to @openedx/frontend-build as a dependency.

Closes #281

* this resolves the need for NEW_RELIC_APP_ID and BASE_URL for New Relic plugins
Copy link

codecov bot commented Feb 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (fc17b47) 70.22% compared to head (f6604b8) 70.22%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #282   +/-   ##
=======================================
  Coverage   70.22%   70.22%           
=======================================
  Files          27       27           
  Lines         403      403           
  Branches       85       85           
=======================================
  Hits          283      283           
  Misses        119      119           
  Partials        1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsnwesson jsnwesson merged commit 2aac86b into master Feb 12, 2024
8 checks passed
@jsnwesson jsnwesson deleted the jwesson/fix-webpack-config-patch branch February 12, 2024 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants