feanil/fix make upgrade #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
September 22, 2023 14:12
We don't use coveralls to aggregate and verify coverage anymore. We use codecove as a part of CI but we don't need it as a python build dependency anymore with the way we use it in github actions. We still install coverage locally to be able to generate the coverage data tha codcov looks for.
Remove some previous pylint supressions that are no longer needed and add a new one for a line that pylint is now complaining about. I'm reluctant to make changes to the code itself since I don't have time to dig depper into this so just supresse the complaint for now.
feanil
force-pushed
the
feanil/fix_make_upgrade
branch
from
58f7210
to
a48c6e5
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #263 +/- ##
=======================================
Coverage 94.14% 94.14%
=======================================
Files 29 29
Lines 2868 2868
Branches 292 219 -73
=======================================
Hits 2700 2700
Misses 142 142
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
make upgrade