[DEPR] Remove EdxRestApiClient usage in edx-enterprise

[feanil]

"Capturing Notes from Slack from Nimisha about what needs to be done here to deal with the JWT tokens in use right now in edx-enterprise:

OAuthAPIClient is intended to be used for backend-to-backend  API calls. (See this ADR.)That is, it works for when Microservice A wants to call Microservice B on behalf of itself (A).It does not work for when Microservice A wants to call Microservice B on behalf of a specific user (U). (edited) 

We typically have frontends needing to call APIs on behalf of users (U).For backend-to-backend, we typically have these calls made in asynchronous celery tasks (in the server’s context) - not within a user’s call.

It looks like the user passed here is a service-user and not an end-user: https:/edx/edx-enterprise/blob/b55a50473775be18505565b99d7966389fb81ca9/enterprise/api_client/discovery.py#L426 

 So… while some additional refactoring will be needed, it shouldn’t require code changes on the Discovery-side.

 Here’s what I believe needs to happen:Configure OAuth Settings ([@Rraposa|https://edx-internal.slack.com/team/UDA40RS1J] Is there an easier way to do this?)

1. edx-enterprise needs to define its own ENTERPRISE_BACKEND_SERVICE_EDX_OAUTH2_KEY and ENTERPRISE_BACKEND_SERVICE_EDX_OAUTH2_SECRET. These ^ are to be shared only with the “User Service” and no other service.
2. You would define values for these on Devstack. For Prod and Stage, you would not have raw access to them, only access to their encrypted forms that you’ll need to configure. You can see how this is done in other services when you search for BACKEND_SERVICE_EDX_OAUTH2_KEY and BACKEND_SERVICE_EDX_OAUTH2_SECRET in https:/edx/edx-internal|https:/edx/edx-internal .
3. Note: edx-enterprise will want to prefix its configuration settings with ENTERPRISE since edx-enterprise is currently a “plugin” in edx-platform instead of its own service - to prevent name collisions with other plugins.
4. Then, add these configured Keys and Secrets in devstack (using provisioning) and each of the necessary environments (stage, prod) using the directions provided at https:/edx/course-discovery/blob/master/docs/advanced.rst#oauth2

Code Changes

Refactor 

CourseCatalogApiServiceClient to no longer get the service user.

Refactor 

CourseCatalogApiClient to no longer require a user.

Refactor 

course_discovery_api_client to no longer build JWTs. Instead use the above configuration settings to call OAuthAPIClient"

Other Info

Original Jira Issue: https://openedx.atlassian.net/browse/DEPR-134

[feanil]

@dyudyunov can you confirm that this can be closed? It looks like all the relevant PRs have merged.

[dyudyunov]

hi, @feanil
confirming, this can be closed